Sorting with Compare Function js
I wrote the following compare function to sort an array of objects. First to have all items starting with "Ro", which are further grouped by their lengths. Then by all items starting with "Bo" and which are also further grouped by their angles and then the rest.
private mycompareFunction(a: T, b: T) {
if(a.name.startsWith("Ro") && b.name.startsWith("Ro")) {
return a.length - b.length;
} else if(b.name.startsWith("Ro")) {
return 1;
} else if(a.name.startsWith("Bo") && b.name.startsWith("Bo")) {
return a.degrees - b.degrees;
} else if(!a.name.startsWith("Ro") && b.name.startsWith("Bo")) {
return 1;
}
return 0;
}
The result I get is:
Ro Ø80/125
Bo Ø80/125, 15°
Bog Ø80/125, 30°
Bo Ø80/125, 45°
Bo Ø80/125, 87°
Ro Ø80/125, 0,5m
Ro Ø80/125, 1,0m
Ro Ø80/125, 2,0m
Gleit
Schieb XXmm
What am I doing wrong here?
javascript sorting
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
asked Nov 22 '18 at 14:46
Tee FTee F
977
add a comment |
I wrote the following compare function to sort an array of objects. First to have all items starting with "Ro", which are further grouped by their lengths. Then by all items starting with "Bo" and which are also further grouped by their angles and then the rest.
private mycompareFunction(a: T, b: T) {
if(a.name.startsWith("Ro") && b.name.startsWith("Ro")) {
return a.length - b.length;
} else if(b.name.startsWith("Ro")) {
return 1;
} else if(a.name.startsWith("Bo") && b.name.startsWith("Bo")) {
return a.degrees - b.degrees;
} else if(!a.name.startsWith("Ro") && b.name.startsWith("Bo")) {
return 1;
}
return 0;
}
The result I get is:
Ro Ø80/125
Bo Ø80/125, 15°
Bog Ø80/125, 30°
Bo Ø80/125, 45°
Bo Ø80/125, 87°
Ro Ø80/125, 0,5m
Ro Ø80/125, 1,0m
Ro Ø80/125, 2,0m
Gleit
Schieb XXmm
What am I doing wrong here?
javascript sorting
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
asked Nov 22 '18 at 14:46
Tee FTee F
977
Apart from what you asked, since you're working with objects, beginning of names are not a trustworthy way to categorize objects. Consider putting an explicit property that indicates in which case an object falls into.
– Pedro Lima
Nov 22 '18 at 15:15
add a comment |
I wrote the following compare function to sort an array of objects. First to have all items starting with "Ro", which are further grouped by their lengths. Then by all items starting with "Bo" and which are also further grouped by their angles and then the rest.
private mycompareFunction(a: T, b: T) {
if(a.name.startsWith("Ro") && b.name.startsWith("Ro")) {
return a.length - b.length;
} else if(b.name.startsWith("Ro")) {
return 1;
} else if(a.name.startsWith("Bo") && b.name.startsWith("Bo")) {
return a.degrees - b.degrees;
} else if(!a.name.startsWith("Ro") && b.name.startsWith("Bo")) {
return 1;
}
return 0;
}
The result I get is:
Ro Ø80/125
Bo Ø80/125, 15°
Bog Ø80/125, 30°
Bo Ø80/125, 45°
Bo Ø80/125, 87°
Ro Ø80/125, 0,5m
Ro Ø80/125, 1,0m
Ro Ø80/125, 2,0m
Gleit
Schieb XXmm
What am I doing wrong here?
javascript sorting
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
asked Nov 22 '18 at 14:46
Tee FTee F
977
I wrote the following compare function to sort an array of objects. First to have all items starting with "Ro", which are further grouped by their lengths. Then by all items starting with "Bo" and which are also further grouped by their angles and then the rest.
private mycompareFunction(a: T, b: T) {
if(a.name.startsWith("Ro") && b.name.startsWith("Ro")) {
return a.length - b.length;
} else if(b.name.startsWith("Ro")) {
return 1;
} else if(a.name.startsWith("Bo") && b.name.startsWith("Bo")) {
return a.degrees - b.degrees;
} else if(!a.name.startsWith("Ro") && b.name.startsWith("Bo")) {
return 1;
}
return 0;
}
The result I get is:
Ro Ø80/125
Bo Ø80/125, 15°
Bog Ø80/125, 30°
Bo Ø80/125, 45°
Bo Ø80/125, 87°
Ro Ø80/125, 0,5m
Ro Ø80/125, 1,0m
Ro Ø80/125, 2,0m
Gleit
Schieb XXmm
What am I doing wrong here?
javascript sorting
javascript sorting
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
asked Nov 22 '18 at 14:46
Tee FTee F
977
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
asked Nov 22 '18 at 14:46
Tee FTee F
977
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
edited Nov 22 '18 at 14:58
yunzen
21.6k85081
21.6k85081
asked Nov 22 '18 at 14:46
Tee FTee F
977
asked Nov 22 '18 at 14:46
Tee FTee F
977
asked Nov 22 '18 at 14:46
Tee FTee F
977
977
Apart from what you asked, since you're working with objects, beginning of names are not a trustworthy way to categorize objects. Consider putting an explicit property that indicates in which case an object falls into.
– Pedro Lima
Nov 22 '18 at 15:15
add a comment |
Apart from what you asked, since you're working with objects, beginning of names are not a trustworthy way to categorize objects. Consider putting an explicit property that indicates in which case an object falls into.
– Pedro Lima
Nov 22 '18 at 15:15
Apart from what you asked, since you're working with objects, beginning of names are not a trustworthy way to categorize objects. Consider putting an explicit property that indicates in which case an object falls into.
– Pedro Lima
Nov 22 '18 at 15:15
Apart from what you asked, since you're working with objects, beginning of names are not a trustworthy way to categorize objects. Consider putting an explicit property that indicates in which case an object falls into.
– Pedro Lima
Nov 22 '18 at 15:15
add a comment |
1 Answer
1
active
oldest
votes
Compare functions should return
- a negative number if the first element should come first
- a positive number if the second element should come first
- zero, if don't matter which of both elements comes first
Your function doesn't contemplate a lot of cases, for exemple, where a starts with "Ro" and b doesn't.
Here is how I would do it:
private mycompareFunction(a: T, b: T) {
if (a.name.startsWith("Ro")) {
if (b.name.startsWith("Ro") {
return a.length - b.length;
} else {
return -1;
}
} else if (a.name.startsWith("Bo") {
if (b.name.startsWith("Ro") {
return 1;
} else if (b.name.startsWith("Bo") {
return a.degrees - b.degrees;
} else {
return -1;
}
} else {
if (b.name.startsWith("Ro") || b.name.startsWith("Bo") {
return 1;
} else {
return 0;
}
}
}
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53433403%2fsorting-with-compare-function-js%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Compare functions should return
- a negative number if the first element should come first
- a positive number if the second element should come first
- zero, if don't matter which of both elements comes first
Your function doesn't contemplate a lot of cases, for exemple, where a starts with "Ro" and b doesn't.
Here is how I would do it:
private mycompareFunction(a: T, b: T) {
if (a.name.startsWith("Ro")) {
if (b.name.startsWith("Ro") {
return a.length - b.length;
} else {
return -1;
}
} else if (a.name.startsWith("Bo") {
if (b.name.startsWith("Ro") {
return 1;
} else if (b.name.startsWith("Bo") {
return a.degrees - b.degrees;
} else {
return -1;
}
} else {
if (b.name.startsWith("Ro") || b.name.startsWith("Bo") {
return 1;
} else {
return 0;
}
}
}
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
add a comment |
Compare functions should return
- a negative number if the first element should come first
- a positive number if the second element should come first
- zero, if don't matter which of both elements comes first
Your function doesn't contemplate a lot of cases, for exemple, where a starts with "Ro" and b doesn't.
Here is how I would do it:
private mycompareFunction(a: T, b: T) {
if (a.name.startsWith("Ro")) {
if (b.name.startsWith("Ro") {
return a.length - b.length;
} else {
return -1;
}
} else if (a.name.startsWith("Bo") {
if (b.name.startsWith("Ro") {
return 1;
} else if (b.name.startsWith("Bo") {
return a.degrees - b.degrees;
} else {
return -1;
}
} else {
if (b.name.startsWith("Ro") || b.name.startsWith("Bo") {
return 1;
} else {
return 0;
}
}
}
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
add a comment |
Compare functions should return
- a negative number if the first element should come first
- a positive number if the second element should come first
- zero, if don't matter which of both elements comes first
Your function doesn't contemplate a lot of cases, for exemple, where a starts with "Ro" and b doesn't.
Here is how I would do it:
private mycompareFunction(a: T, b: T) {
if (a.name.startsWith("Ro")) {
if (b.name.startsWith("Ro") {
return a.length - b.length;
} else {
return -1;
}
} else if (a.name.startsWith("Bo") {
if (b.name.startsWith("Ro") {
return 1;
} else if (b.name.startsWith("Bo") {
return a.degrees - b.degrees;
} else {
return -1;
}
} else {
if (b.name.startsWith("Ro") || b.name.startsWith("Bo") {
return 1;
} else {
return 0;
}
}
}
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
Compare functions should return
- a negative number if the first element should come first
- a positive number if the second element should come first
- zero, if don't matter which of both elements comes first
Your function doesn't contemplate a lot of cases, for exemple, where a starts with "Ro" and b doesn't.
Here is how I would do it:
private mycompareFunction(a: T, b: T) {
if (a.name.startsWith("Ro")) {
if (b.name.startsWith("Ro") {
return a.length - b.length;
} else {
return -1;
}
} else if (a.name.startsWith("Bo") {
if (b.name.startsWith("Ro") {
return 1;
} else if (b.name.startsWith("Bo") {
return a.degrees - b.degrees;
} else {
return -1;
}
} else {
if (b.name.startsWith("Ro") || b.name.startsWith("Bo") {
return 1;
} else {
return 0;
}
}
}
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
answered Nov 22 '18 at 15:10
Pedro LimaPedro Lima
415411
415411
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53433403%2fsorting-with-compare-function-js%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Apart from what you asked, since you're working with objects, beginning of names are not a trustworthy way to categorize objects. Consider putting an explicit property that indicates in which case an object falls into.
– Pedro Lima
Nov 22 '18 at 15:15