Flow type checking for overriden static function extended type argument
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
I have some basic type that is processing with some class static function. Also I have an extended type, so I want to write an extended class to process it the same way with code reuse.
The code works find, but I can't figure out how to make flow happy here.
Here is a small example:
// @flow
type Data = {
id: number
}
type ExtendedData = Data & {
name: string
}
class SomeClass {
static something(some: Data): this {
return new this(); // returns SomeClass
}
}
class SomeOtherClass extends SomeClass {
// flow: Cannot extend `SomeClass` [1] with `SomeOtherClass`
// because property `name` is missing in `Data` [2] but exists in
// object type [3] in the first argument of property `something`.
static something(some: ExtendedData): this {
return /* returns SomeOtherClass here */ super.something(some);
}
}
javascript flowtype
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
add a comment |
I have some basic type that is processing with some class static function. Also I have an extended type, so I want to write an extended class to process it the same way with code reuse.
The code works find, but I can't figure out how to make flow happy here.
Here is a small example:
// @flow
type Data = {
id: number
}
type ExtendedData = Data & {
name: string
}
class SomeClass {
static something(some: Data): this {
return new this(); // returns SomeClass
}
}
class SomeOtherClass extends SomeClass {
// flow: Cannot extend `SomeClass` [1] with `SomeOtherClass`
// because property `name` is missing in `Data` [2] but exists in
// object type [3] in the first argument of property `something`.
static something(some: ExtendedData): this {
return /* returns SomeOtherClass here */ super.something(some);
}
}
javascript flowtype
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
add a comment |
I have some basic type that is processing with some class static function. Also I have an extended type, so I want to write an extended class to process it the same way with code reuse.
The code works find, but I can't figure out how to make flow happy here.
Here is a small example:
// @flow
type Data = {
id: number
}
type ExtendedData = Data & {
name: string
}
class SomeClass {
static something(some: Data): this {
return new this(); // returns SomeClass
}
}
class SomeOtherClass extends SomeClass {
// flow: Cannot extend `SomeClass` [1] with `SomeOtherClass`
// because property `name` is missing in `Data` [2] but exists in
// object type [3] in the first argument of property `something`.
static something(some: ExtendedData): this {
return /* returns SomeOtherClass here */ super.something(some);
}
}
javascript flowtype
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
I have some basic type that is processing with some class static function. Also I have an extended type, so I want to write an extended class to process it the same way with code reuse.
The code works find, but I can't figure out how to make flow happy here.
Here is a small example:
// @flow
type Data = {
id: number
}
type ExtendedData = Data & {
name: string
}
class SomeClass {
static something(some: Data): this {
return new this(); // returns SomeClass
}
}
class SomeOtherClass extends SomeClass {
// flow: Cannot extend `SomeClass` [1] with `SomeOtherClass`
// because property `name` is missing in `Data` [2] but exists in
// object type [3] in the first argument of property `something`.
static something(some: ExtendedData): this {
return /* returns SomeOtherClass here */ super.something(some);
}
}
javascript flowtype
javascript flowtype
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
asked Nov 23 '18 at 16:17
silentsilent
2,9991729
2,9991729
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
The point flow complains is similar to this one, your implementation breaks L in SOLID i.e. it'll fail in next case:
const f = (S: Class<SomeClass>) => {
S.something({id: 1})
}
f(SomeClass); // ok
f(SomeOtherClass); // fail, no name property
You can say him that only Data is ok as well for SomeOtherClass, and he'll be happy:
static something(some: Data | ExtendedData): this {...}
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
Both are not cool :(
– silent
Nov 25 '18 at 9:31
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53449971%2fflow-type-checking-for-overriden-static-function-extended-type-argument%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
The point flow complains is similar to this one, your implementation breaks L in SOLID i.e. it'll fail in next case:
const f = (S: Class<SomeClass>) => {
S.something({id: 1})
}
f(SomeClass); // ok
f(SomeOtherClass); // fail, no name property
You can say him that only Data is ok as well for SomeOtherClass, and he'll be happy:
static something(some: Data | ExtendedData): this {...}
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
Both are not cool :(
– silent
Nov 25 '18 at 9:31
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
add a comment |
The point flow complains is similar to this one, your implementation breaks L in SOLID i.e. it'll fail in next case:
const f = (S: Class<SomeClass>) => {
S.something({id: 1})
}
f(SomeClass); // ok
f(SomeOtherClass); // fail, no name property
You can say him that only Data is ok as well for SomeOtherClass, and he'll be happy:
static something(some: Data | ExtendedData): this {...}
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
Both are not cool :(
– silent
Nov 25 '18 at 9:31
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
add a comment |
The point flow complains is similar to this one, your implementation breaks L in SOLID i.e. it'll fail in next case:
const f = (S: Class<SomeClass>) => {
S.something({id: 1})
}
f(SomeClass); // ok
f(SomeOtherClass); // fail, no name property
You can say him that only Data is ok as well for SomeOtherClass, and he'll be happy:
static something(some: Data | ExtendedData): this {...}
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
The point flow complains is similar to this one, your implementation breaks L in SOLID i.e. it'll fail in next case:
const f = (S: Class<SomeClass>) => {
S.something({id: 1})
}
f(SomeClass); // ok
f(SomeOtherClass); // fail, no name property
You can say him that only Data is ok as well for SomeOtherClass, and he'll be happy:
static something(some: Data | ExtendedData): this {...}
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
edited Nov 25 '18 at 18:44
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
answered Nov 24 '18 at 11:10
AlexAlex
3,553823
3,553823
Both are not cool :(
– silent
Nov 25 '18 at 9:31
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
add a comment |
Both are not cool :(
– silent
Nov 25 '18 at 9:31
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
Both are not cool :(
– silent
Nov 25 '18 at 9:31
Both are not cool :(
– silent
Nov 25 '18 at 9:31
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
@silent, okay, found something simpler for you
– Alex
Nov 25 '18 at 17:55
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53449971%2fflow-type-checking-for-overriden-static-function-extended-type-argument%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
