Dynamic Variables stored in object not updating value when changed












0














I stored dynamic variables in an object called newEvent. The variables values change, but when I store them in newEvent they keep the same value that they had when they were first loaded and they don't change values when they are updated. Here is my code



let headerMonths = document.getElementsByClassName('month')[0];
let headerYears = document.getElementsByClassName('year')[0];

let newEvent = {
// day: parseInt(event.innerHTML),
title: document.querySelector('#new-event-title'),
desc: document.querySelector('#new-event-desc'),
month: headerMonths.innerHTML,
year: headerYears.innerHTML,
active: document.getElementsByClassName('active')[0],
submit: ()=>{
if(newEvent.title.value.length===0){
console.log('sasc');
newEvent.title.classList.add('error');
} else if(newEvent.desc.value.length===0) {
newEvent.desc.classList.add('error');
} else {
newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month, newEvent.year, newEvent.active.innerHTML);
}
}
};

document.querySelector('#submit-event').addEventListener('click', (e)=>{
e.preventDefault();
newEvent.submit();
});


The only variables whose values are changing in newEvent are newEvent.title and newEvent.desc, which are html input's inside a form. Why is this happening and how can I get the changed valued of the variables?










share|improve this question





























    0














    I stored dynamic variables in an object called newEvent. The variables values change, but when I store them in newEvent they keep the same value that they had when they were first loaded and they don't change values when they are updated. Here is my code



    let headerMonths = document.getElementsByClassName('month')[0];
    let headerYears = document.getElementsByClassName('year')[0];

    let newEvent = {
    // day: parseInt(event.innerHTML),
    title: document.querySelector('#new-event-title'),
    desc: document.querySelector('#new-event-desc'),
    month: headerMonths.innerHTML,
    year: headerYears.innerHTML,
    active: document.getElementsByClassName('active')[0],
    submit: ()=>{
    if(newEvent.title.value.length===0){
    console.log('sasc');
    newEvent.title.classList.add('error');
    } else if(newEvent.desc.value.length===0) {
    newEvent.desc.classList.add('error');
    } else {
    newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month, newEvent.year, newEvent.active.innerHTML);
    }
    }
    };

    document.querySelector('#submit-event').addEventListener('click', (e)=>{
    e.preventDefault();
    newEvent.submit();
    });


    The only variables whose values are changing in newEvent are newEvent.title and newEvent.desc, which are html input's inside a form. Why is this happening and how can I get the changed valued of the variables?










    share|improve this question



























      0












      0








      0


      0





      I stored dynamic variables in an object called newEvent. The variables values change, but when I store them in newEvent they keep the same value that they had when they were first loaded and they don't change values when they are updated. Here is my code



      let headerMonths = document.getElementsByClassName('month')[0];
      let headerYears = document.getElementsByClassName('year')[0];

      let newEvent = {
      // day: parseInt(event.innerHTML),
      title: document.querySelector('#new-event-title'),
      desc: document.querySelector('#new-event-desc'),
      month: headerMonths.innerHTML,
      year: headerYears.innerHTML,
      active: document.getElementsByClassName('active')[0],
      submit: ()=>{
      if(newEvent.title.value.length===0){
      console.log('sasc');
      newEvent.title.classList.add('error');
      } else if(newEvent.desc.value.length===0) {
      newEvent.desc.classList.add('error');
      } else {
      newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month, newEvent.year, newEvent.active.innerHTML);
      }
      }
      };

      document.querySelector('#submit-event').addEventListener('click', (e)=>{
      e.preventDefault();
      newEvent.submit();
      });


      The only variables whose values are changing in newEvent are newEvent.title and newEvent.desc, which are html input's inside a form. Why is this happening and how can I get the changed valued of the variables?










      share|improve this question















      I stored dynamic variables in an object called newEvent. The variables values change, but when I store them in newEvent they keep the same value that they had when they were first loaded and they don't change values when they are updated. Here is my code



      let headerMonths = document.getElementsByClassName('month')[0];
      let headerYears = document.getElementsByClassName('year')[0];

      let newEvent = {
      // day: parseInt(event.innerHTML),
      title: document.querySelector('#new-event-title'),
      desc: document.querySelector('#new-event-desc'),
      month: headerMonths.innerHTML,
      year: headerYears.innerHTML,
      active: document.getElementsByClassName('active')[0],
      submit: ()=>{
      if(newEvent.title.value.length===0){
      console.log('sasc');
      newEvent.title.classList.add('error');
      } else if(newEvent.desc.value.length===0) {
      newEvent.desc.classList.add('error');
      } else {
      newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month, newEvent.year, newEvent.active.innerHTML);
      }
      }
      };

      document.querySelector('#submit-event').addEventListener('click', (e)=>{
      e.preventDefault();
      newEvent.submit();
      });


      The only variables whose values are changing in newEvent are newEvent.title and newEvent.desc, which are html input's inside a form. Why is this happening and how can I get the changed valued of the variables?







      javascript object dom ecmascript-6






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 11 at 20:59

























      asked Nov 11 at 20:49









      icewizard

      589




      589
























          2 Answers
          2






          active

          oldest

          votes


















          0














          The reason that title and description are the only values changing is because you're setting them in newEvent as the query selector result for their corresponding DOM element. Whereas the other values including month, year and active, are either strings or numbers/bools.






          share|improve this answer





















          • I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
            – icewizard
            Nov 11 at 21:04



















          0














          I changed my code to this



          let newEvent = {
          // day: parseInt(event.innerHTML),
          title: document.querySelector('#new-event-title'),
          desc: document.querySelector('#new-event-desc'),
          month: headerMonths,
          year: headerYears,
          active: document.getElementsByClassName('active'),
          submit: ()=>{
          if(newEvent.title.value.length===0){
          console.log('sasc');
          newEvent.title.classList.add('error');
          } else if(newEvent.desc.value.length===0) {
          newEvent.desc.classList.add('error');
          } else {
          newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month.innerHTML, newEvent.year.innerHTML, newEvent.active[0].innerHTML);
          }
          }
          };


          and now the values are updating. It must be because when I declared the object keys I accessed the current value of the element before I changed it and it never updated when I call the submit function, but now the direct value or html of the element is only accessed when I call the newEvent.submit function and this is getting my changes to those elements.






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53253096%2fdynamic-variables-stored-in-object-not-updating-value-when-changed%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            2 Answers
            2






            active

            oldest

            votes








            2 Answers
            2






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0














            The reason that title and description are the only values changing is because you're setting them in newEvent as the query selector result for their corresponding DOM element. Whereas the other values including month, year and active, are either strings or numbers/bools.






            share|improve this answer





















            • I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
              – icewizard
              Nov 11 at 21:04
















            0














            The reason that title and description are the only values changing is because you're setting them in newEvent as the query selector result for their corresponding DOM element. Whereas the other values including month, year and active, are either strings or numbers/bools.






            share|improve this answer





















            • I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
              – icewizard
              Nov 11 at 21:04














            0












            0








            0






            The reason that title and description are the only values changing is because you're setting them in newEvent as the query selector result for their corresponding DOM element. Whereas the other values including month, year and active, are either strings or numbers/bools.






            share|improve this answer












            The reason that title and description are the only values changing is because you're setting them in newEvent as the query selector result for their corresponding DOM element. Whereas the other values including month, year and active, are either strings or numbers/bools.







            share|improve this answer












            share|improve this answer



            share|improve this answer










            answered Nov 11 at 20:57









            Callam

            7,81221522




            7,81221522












            • I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
              – icewizard
              Nov 11 at 21:04


















            • I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
              – icewizard
              Nov 11 at 21:04
















            I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
            – icewizard
            Nov 11 at 21:04




            I'm getting the value of the element from newEvent.title and newEvent.desc, I get the other elements directly through their class name and I access their innerHTML which changes. if I type these selectors in my browser console I get the correct value that they are changed to, but it doesn't change in the newEvent object. Do I have to use a query Selector to get the changes of the element?
            – icewizard
            Nov 11 at 21:04













            0














            I changed my code to this



            let newEvent = {
            // day: parseInt(event.innerHTML),
            title: document.querySelector('#new-event-title'),
            desc: document.querySelector('#new-event-desc'),
            month: headerMonths,
            year: headerYears,
            active: document.getElementsByClassName('active'),
            submit: ()=>{
            if(newEvent.title.value.length===0){
            console.log('sasc');
            newEvent.title.classList.add('error');
            } else if(newEvent.desc.value.length===0) {
            newEvent.desc.classList.add('error');
            } else {
            newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month.innerHTML, newEvent.year.innerHTML, newEvent.active[0].innerHTML);
            }
            }
            };


            and now the values are updating. It must be because when I declared the object keys I accessed the current value of the element before I changed it and it never updated when I call the submit function, but now the direct value or html of the element is only accessed when I call the newEvent.submit function and this is getting my changes to those elements.






            share|improve this answer


























              0














              I changed my code to this



              let newEvent = {
              // day: parseInt(event.innerHTML),
              title: document.querySelector('#new-event-title'),
              desc: document.querySelector('#new-event-desc'),
              month: headerMonths,
              year: headerYears,
              active: document.getElementsByClassName('active'),
              submit: ()=>{
              if(newEvent.title.value.length===0){
              console.log('sasc');
              newEvent.title.classList.add('error');
              } else if(newEvent.desc.value.length===0) {
              newEvent.desc.classList.add('error');
              } else {
              newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month.innerHTML, newEvent.year.innerHTML, newEvent.active[0].innerHTML);
              }
              }
              };


              and now the values are updating. It must be because when I declared the object keys I accessed the current value of the element before I changed it and it never updated when I call the submit function, but now the direct value or html of the element is only accessed when I call the newEvent.submit function and this is getting my changes to those elements.






              share|improve this answer
























                0












                0








                0






                I changed my code to this



                let newEvent = {
                // day: parseInt(event.innerHTML),
                title: document.querySelector('#new-event-title'),
                desc: document.querySelector('#new-event-desc'),
                month: headerMonths,
                year: headerYears,
                active: document.getElementsByClassName('active'),
                submit: ()=>{
                if(newEvent.title.value.length===0){
                console.log('sasc');
                newEvent.title.classList.add('error');
                } else if(newEvent.desc.value.length===0) {
                newEvent.desc.classList.add('error');
                } else {
                newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month.innerHTML, newEvent.year.innerHTML, newEvent.active[0].innerHTML);
                }
                }
                };


                and now the values are updating. It must be because when I declared the object keys I accessed the current value of the element before I changed it and it never updated when I call the submit function, but now the direct value or html of the element is only accessed when I call the newEvent.submit function and this is getting my changes to those elements.






                share|improve this answer












                I changed my code to this



                let newEvent = {
                // day: parseInt(event.innerHTML),
                title: document.querySelector('#new-event-title'),
                desc: document.querySelector('#new-event-desc'),
                month: headerMonths,
                year: headerYears,
                active: document.getElementsByClassName('active'),
                submit: ()=>{
                if(newEvent.title.value.length===0){
                console.log('sasc');
                newEvent.title.classList.add('error');
                } else if(newEvent.desc.value.length===0) {
                newEvent.desc.classList.add('error');
                } else {
                newEventJson(newEvent.title.value, newEvent.desc.value, newEvent.month.innerHTML, newEvent.year.innerHTML, newEvent.active[0].innerHTML);
                }
                }
                };


                and now the values are updating. It must be because when I declared the object keys I accessed the current value of the element before I changed it and it never updated when I call the submit function, but now the direct value or html of the element is only accessed when I call the newEvent.submit function and this is getting my changes to those elements.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 11 at 21:13









                icewizard

                589




                589






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53253096%2fdynamic-variables-stored-in-object-not-updating-value-when-changed%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    這個網誌中的熱門文章

                    Tangent Lines Diagram Along Smooth Curve

                    Yusuf al-Mu'taman ibn Hud

                    Zucchini