Wsrtjtyk

I am currently developing a REST Api using Slim Framework with a Layered Architecture:

Controller->Service->Repository->DB

My problem is the save() function on one of my services contains a collection of complex functions which clearly violates the Separation of Responsibility Principle so I grouped the functions based on their "responsibilities". Here are some of it:

• Data Validation


• Record Locking


• Edit History Logging


• Destination Delegation

These functions are not always executed. It executes depending on the data passed onto the service and some of the functions blocks the saving if a business rule is violated. Currently,I am planning to solve it using the Chain-of-Responsibility Pattern

class PropertyController

{

    public function saveAction($request, $response, $args)

    {

        $data = $req->getParsedBody();



        $dataValidation = new DataValidation();

        $recordLocking = new RecordLocking();

        $editHistoryLogging = new EditHistoryLogging();

        $destinationDelegation = new DestinationDelegation();



        $dataValidation->next($recordLocking);

        $recordLocking->next($editHistoryLogging);

        $editHistoryLogging->next($destinationDelegation);



        $propertyService = new PropertyService(new PropertyEloquentRepository());

        $result = $propertyService->save($data, $dataValidation);



        return $response->withStatus(200)

            ->withHeader('Content-Type','application/json')

            ->write(json_encode($result));

    }

}

Is this implementation fine and is considered a good practice?