Sonar Rule: Symbol and SymbolType always unknown
2
Creating a sonar rule:
Class to check:
import java.util.concurrent.locks.*;
public class SonarTestClass {
public void main() {
ReadWriteLock rwl = new ReentrantReadWriteLock();
Lock writeLock = rwl.writeLock();
writeLock.lock();
StampedLock lock = new StampedLock();
long stampedReadLock = lock.readLock();
ReentrantLock reeLock = new ReentrantLock();
reeLock.lock();
ReadWriteLock rwl1 = new ReentrantReadWriteLock();
Lock writeLock1 = rwl1.writeLock();
writeLock1.lock();
try{
foo();
} finally {
writeLock1.unlock();
}
StampedLock stampedLock1 = new StampedLock();
long stampedReadLock1 = stampedLock1.readLock();
try{
foo();
} finally {
stampedLock1.unlock(stampedReadLock1);
}
ReentrantLock reeLock1 = new ReentrantLock();
reeLock1.lock();
try{
foo();
} finally {
reeLock1.unlock();
}
}
private void foo() {
}
Rule:
@Rule(key = "TSS0008")
public class LocksReleasedCheck extends IssuableSubscriptionVisitor {
@Override
public List<Tree.Kind> nodesToVisit() {
return ImmutableList.of(Tree.Kind.METHOD_INVOCATION);
}
@Override
public void visitNode(Tree tree) {
MethodInvocationTree mit = (MethodInvocationTree) tree;
if(!mit.methodSelect().is((Tree.Kind.MEMBER_SELECT))) {
return;
}
MemberSelectExpressionTree memberSelectExpressionTree = (MemberSelectExpressionTree) mit.methodSelect();
ExpressionTree expression = memberSelectExpressionTree.expression();
if(expression.is(Tree.Kind.IDENTIFIER)) { //&& expression.symbolType().isSubtypeOf("java.util.concurrent.locks.Lock")){
IdentifierTree identifier = memberSelectExpressionTree.identifier();
System.out.println(identifier.symbol());
}
}
}
But expression.symbolType() and identifier.symbol() do always return unkown type/unkown symbol when testing the rule with a unit test or with gradle test.
The sysout prints: !unknownSymbol!
Is there any reason it does not return the type (ReadWriteLock, Lock,..) ?
java unit-testing sonarqube
asked Nov 22 '18 at 9:56
marksRmarksR
113
add a comment |
2
Creating a sonar rule:
Class to check:
import java.util.concurrent.locks.*;
public class SonarTestClass {
public void main() {
ReadWriteLock rwl = new ReentrantReadWriteLock();
Lock writeLock = rwl.writeLock();
writeLock.lock();
StampedLock lock = new StampedLock();
long stampedReadLock = lock.readLock();
ReentrantLock reeLock = new ReentrantLock();
reeLock.lock();
ReadWriteLock rwl1 = new ReentrantReadWriteLock();
Lock writeLock1 = rwl1.writeLock();
writeLock1.lock();
try{
foo();
} finally {
writeLock1.unlock();
}
StampedLock stampedLock1 = new StampedLock();
long stampedReadLock1 = stampedLock1.readLock();
try{
foo();
} finally {
stampedLock1.unlock(stampedReadLock1);
}
ReentrantLock reeLock1 = new ReentrantLock();
reeLock1.lock();
try{
foo();
} finally {
reeLock1.unlock();
}
}
private void foo() {
}
Rule:
@Rule(key = "TSS0008")
public class LocksReleasedCheck extends IssuableSubscriptionVisitor {
@Override
public List<Tree.Kind> nodesToVisit() {
return ImmutableList.of(Tree.Kind.METHOD_INVOCATION);
}
@Override
public void visitNode(Tree tree) {
MethodInvocationTree mit = (MethodInvocationTree) tree;
if(!mit.methodSelect().is((Tree.Kind.MEMBER_SELECT))) {
return;
}
MemberSelectExpressionTree memberSelectExpressionTree = (MemberSelectExpressionTree) mit.methodSelect();
ExpressionTree expression = memberSelectExpressionTree.expression();
if(expression.is(Tree.Kind.IDENTIFIER)) { //&& expression.symbolType().isSubtypeOf("java.util.concurrent.locks.Lock")){
IdentifierTree identifier = memberSelectExpressionTree.identifier();
System.out.println(identifier.symbol());
}
}
}
But expression.symbolType() and identifier.symbol() do always return unkown type/unkown symbol when testing the rule with a unit test or with gradle test.
The sysout prints: !unknownSymbol!
Is there any reason it does not return the type (ReadWriteLock, Lock,..) ?
java unit-testing sonarqube
asked Nov 22 '18 at 9:56
marksRmarksR
113
add a comment |
2
2
2
2
Creating a sonar rule:
Class to check:
import java.util.concurrent.locks.*;
public class SonarTestClass {
public void main() {
ReadWriteLock rwl = new ReentrantReadWriteLock();
Lock writeLock = rwl.writeLock();
writeLock.lock();
StampedLock lock = new StampedLock();
long stampedReadLock = lock.readLock();
ReentrantLock reeLock = new ReentrantLock();
reeLock.lock();
ReadWriteLock rwl1 = new ReentrantReadWriteLock();
Lock writeLock1 = rwl1.writeLock();
writeLock1.lock();
try{
foo();
} finally {
writeLock1.unlock();
}
StampedLock stampedLock1 = new StampedLock();
long stampedReadLock1 = stampedLock1.readLock();
try{
foo();
} finally {
stampedLock1.unlock(stampedReadLock1);
}
ReentrantLock reeLock1 = new ReentrantLock();
reeLock1.lock();
try{
foo();
} finally {
reeLock1.unlock();
}
}
private void foo() {
}
Rule:
@Rule(key = "TSS0008")
public class LocksReleasedCheck extends IssuableSubscriptionVisitor {
@Override
public List<Tree.Kind> nodesToVisit() {
return ImmutableList.of(Tree.Kind.METHOD_INVOCATION);
}
@Override
public void visitNode(Tree tree) {
MethodInvocationTree mit = (MethodInvocationTree) tree;
if(!mit.methodSelect().is((Tree.Kind.MEMBER_SELECT))) {
return;
}
MemberSelectExpressionTree memberSelectExpressionTree = (MemberSelectExpressionTree) mit.methodSelect();
ExpressionTree expression = memberSelectExpressionTree.expression();
if(expression.is(Tree.Kind.IDENTIFIER)) { //&& expression.symbolType().isSubtypeOf("java.util.concurrent.locks.Lock")){
IdentifierTree identifier = memberSelectExpressionTree.identifier();
System.out.println(identifier.symbol());
}
}
}
But expression.symbolType() and identifier.symbol() do always return unkown type/unkown symbol when testing the rule with a unit test or with gradle test.
The sysout prints: !unknownSymbol!
Is there any reason it does not return the type (ReadWriteLock, Lock,..) ?
java unit-testing sonarqube
asked Nov 22 '18 at 9:56
marksRmarksR
113
Creating a sonar rule:
Class to check:
import java.util.concurrent.locks.*;
public class SonarTestClass {
public void main() {
ReadWriteLock rwl = new ReentrantReadWriteLock();
Lock writeLock = rwl.writeLock();
writeLock.lock();
StampedLock lock = new StampedLock();
long stampedReadLock = lock.readLock();
ReentrantLock reeLock = new ReentrantLock();
reeLock.lock();
ReadWriteLock rwl1 = new ReentrantReadWriteLock();
Lock writeLock1 = rwl1.writeLock();
writeLock1.lock();
try{
foo();
} finally {
writeLock1.unlock();
}
StampedLock stampedLock1 = new StampedLock();
long stampedReadLock1 = stampedLock1.readLock();
try{
foo();
} finally {
stampedLock1.unlock(stampedReadLock1);
}
ReentrantLock reeLock1 = new ReentrantLock();
reeLock1.lock();
try{
foo();
} finally {
reeLock1.unlock();
}
}
private void foo() {
}
Rule:
@Rule(key = "TSS0008")
public class LocksReleasedCheck extends IssuableSubscriptionVisitor {
@Override
public List<Tree.Kind> nodesToVisit() {
return ImmutableList.of(Tree.Kind.METHOD_INVOCATION);
}
@Override
public void visitNode(Tree tree) {
MethodInvocationTree mit = (MethodInvocationTree) tree;
if(!mit.methodSelect().is((Tree.Kind.MEMBER_SELECT))) {
return;
}
MemberSelectExpressionTree memberSelectExpressionTree = (MemberSelectExpressionTree) mit.methodSelect();
ExpressionTree expression = memberSelectExpressionTree.expression();
if(expression.is(Tree.Kind.IDENTIFIER)) { //&& expression.symbolType().isSubtypeOf("java.util.concurrent.locks.Lock")){
IdentifierTree identifier = memberSelectExpressionTree.identifier();
System.out.println(identifier.symbol());
}
}
}
But expression.symbolType() and identifier.symbol() do always return unkown type/unkown symbol when testing the rule with a unit test or with gradle test.
The sysout prints: !unknownSymbol!
Is there any reason it does not return the type (ReadWriteLock, Lock,..) ?
java unit-testing sonarqube
java unit-testing sonarqube
asked Nov 22 '18 at 9:56
marksRmarksR
113
asked Nov 22 '18 at 9:56
marksRmarksR
113
edited Nov 22 '18 at 10:09
marksR
asked Nov 22 '18 at 9:56
marksRmarksR
113
asked Nov 22 '18 at 9:56
marksRmarksR
113
asked Nov 22 '18 at 9:56
marksRmarksR
113
113
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53428266%2fsonar-rule-symbol-and-symboltype-always-unknown%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53428266%2fsonar-rule-symbol-and-symboltype-always-unknown%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
