Getting new data from Effect/Reducer/Action pattern
Okay, so I cant seem to figure out how to do this more efficiently. To be completely frank I don't really understand this pattern very well, but I got thrown in the deep-end. So I have a resolver getting the observable for an appropriate Plan for a form. However, due to the page I'm navigating from, I have done effectively a lightload of plan, which is stored in state. So when the load occurs instead of returning the fully hyrdated object, i get a light load. The only thing I've figured out how to fix is by removing it from state first. This seems silly. How can I configure the effect to do a remove/load, maybe by passing a param?
export class PlanResolver implements Resolve<Observable<Plan>> {
public plan$: Observable<Plan>;
constructor(public store: Store<fromRoot.State>) {
this.plan$ = store.select<Plan>(fromRoot.getSelectedPlan);
}
resolve(route: ActivatedRouteSnapshot) {
let id = +route.paramMap.get('id');
console.info(id);
this.store.dispatch(new PlanActions.Remove(id)); //This seems silly
this.store.dispatch(new PlanActions.Load(id));
return of(this.plan$);
}
reducer:
case PlanActionTypes.LoadSuccess: {
return adapter.addOne(action.payload, {
...state,
selectedPlanId: state.selectedPlanId,
});
}
case PlanActionTypes.Load: {
return {
...state,
selectedPlanId: action.payload,
};
}
Effect:
@Effect()
loadPlan$: Observable<Action> = this.actions$
.ofType<Load>(PlanActionTypes.Load).pipe(
switchMap(action => this.planService.getPlan(action.payload)),
map((plan: Plan) => new LoadSuccess(plan)),
catchError(err => {
toastr.error(`Could not load plan.`);
console.error(err);
return of(new LoadFail(err));
})
);
Action:
export class Load implements Action {
readonly type = PlanActionTypes.Load;
constructor(public payload: number) {}
}
export class LoadSuccess implements Action {
readonly type = PlanActionTypes.LoadSuccess;
constructor(public payload: Plan) {}
}
export class LoadFail implements Action {
readonly type = PlanActionTypes.LoadFail;
constructor(public payload: any) {}
}
EDIT:
So Im getting
Plan{
a: Value
b: value
c - z: null
}
and I'm expecting
Plan{
a:value
....
z: value
}
By removing first i get the expected result.
angular typescript ngrx-store
asked Nov 14 '18 at 3:02
SethSeth
3201220
add a comment |
Okay, so I cant seem to figure out how to do this more efficiently. To be completely frank I don't really understand this pattern very well, but I got thrown in the deep-end. So I have a resolver getting the observable for an appropriate Plan for a form. However, due to the page I'm navigating from, I have done effectively a lightload of plan, which is stored in state. So when the load occurs instead of returning the fully hyrdated object, i get a light load. The only thing I've figured out how to fix is by removing it from state first. This seems silly. How can I configure the effect to do a remove/load, maybe by passing a param?
export class PlanResolver implements Resolve<Observable<Plan>> {
public plan$: Observable<Plan>;
constructor(public store: Store<fromRoot.State>) {
this.plan$ = store.select<Plan>(fromRoot.getSelectedPlan);
}
resolve(route: ActivatedRouteSnapshot) {
let id = +route.paramMap.get('id');
console.info(id);
this.store.dispatch(new PlanActions.Remove(id)); //This seems silly
this.store.dispatch(new PlanActions.Load(id));
return of(this.plan$);
}
reducer:
case PlanActionTypes.LoadSuccess: {
return adapter.addOne(action.payload, {
...state,
selectedPlanId: state.selectedPlanId,
});
}
case PlanActionTypes.Load: {
return {
...state,
selectedPlanId: action.payload,
};
}
Effect:
@Effect()
loadPlan$: Observable<Action> = this.actions$
.ofType<Load>(PlanActionTypes.Load).pipe(
switchMap(action => this.planService.getPlan(action.payload)),
map((plan: Plan) => new LoadSuccess(plan)),
catchError(err => {
toastr.error(`Could not load plan.`);
console.error(err);
return of(new LoadFail(err));
})
);
Action:
export class Load implements Action {
readonly type = PlanActionTypes.Load;
constructor(public payload: number) {}
}
export class LoadSuccess implements Action {
readonly type = PlanActionTypes.LoadSuccess;
constructor(public payload: Plan) {}
}
export class LoadFail implements Action {
readonly type = PlanActionTypes.LoadFail;
constructor(public payload: any) {}
}
EDIT:
So Im getting
Plan{
a: Value
b: value
c - z: null
}
and I'm expecting
Plan{
a:value
....
z: value
}
By removing first i get the expected result.
angular typescript ngrx-store
asked Nov 14 '18 at 3:02
SethSeth
3201220
add a comment |
Okay, so I cant seem to figure out how to do this more efficiently. To be completely frank I don't really understand this pattern very well, but I got thrown in the deep-end. So I have a resolver getting the observable for an appropriate Plan for a form. However, due to the page I'm navigating from, I have done effectively a lightload of plan, which is stored in state. So when the load occurs instead of returning the fully hyrdated object, i get a light load. The only thing I've figured out how to fix is by removing it from state first. This seems silly. How can I configure the effect to do a remove/load, maybe by passing a param?
export class PlanResolver implements Resolve<Observable<Plan>> {
public plan$: Observable<Plan>;
constructor(public store: Store<fromRoot.State>) {
this.plan$ = store.select<Plan>(fromRoot.getSelectedPlan);
}
resolve(route: ActivatedRouteSnapshot) {
let id = +route.paramMap.get('id');
console.info(id);
this.store.dispatch(new PlanActions.Remove(id)); //This seems silly
this.store.dispatch(new PlanActions.Load(id));
return of(this.plan$);
}
reducer:
case PlanActionTypes.LoadSuccess: {
return adapter.addOne(action.payload, {
...state,
selectedPlanId: state.selectedPlanId,
});
}
case PlanActionTypes.Load: {
return {
...state,
selectedPlanId: action.payload,
};
}
Effect:
@Effect()
loadPlan$: Observable<Action> = this.actions$
.ofType<Load>(PlanActionTypes.Load).pipe(
switchMap(action => this.planService.getPlan(action.payload)),
map((plan: Plan) => new LoadSuccess(plan)),
catchError(err => {
toastr.error(`Could not load plan.`);
console.error(err);
return of(new LoadFail(err));
})
);
Action:
export class Load implements Action {
readonly type = PlanActionTypes.Load;
constructor(public payload: number) {}
}
export class LoadSuccess implements Action {
readonly type = PlanActionTypes.LoadSuccess;
constructor(public payload: Plan) {}
}
export class LoadFail implements Action {
readonly type = PlanActionTypes.LoadFail;
constructor(public payload: any) {}
}
EDIT:
So Im getting
Plan{
a: Value
b: value
c - z: null
}
and I'm expecting
Plan{
a:value
....
z: value
}
By removing first i get the expected result.
angular typescript ngrx-store
asked Nov 14 '18 at 3:02
SethSeth
3201220
Okay, so I cant seem to figure out how to do this more efficiently. To be completely frank I don't really understand this pattern very well, but I got thrown in the deep-end. So I have a resolver getting the observable for an appropriate Plan for a form. However, due to the page I'm navigating from, I have done effectively a lightload of plan, which is stored in state. So when the load occurs instead of returning the fully hyrdated object, i get a light load. The only thing I've figured out how to fix is by removing it from state first. This seems silly. How can I configure the effect to do a remove/load, maybe by passing a param?
export class PlanResolver implements Resolve<Observable<Plan>> {
public plan$: Observable<Plan>;
constructor(public store: Store<fromRoot.State>) {
this.plan$ = store.select<Plan>(fromRoot.getSelectedPlan);
}
resolve(route: ActivatedRouteSnapshot) {
let id = +route.paramMap.get('id');
console.info(id);
this.store.dispatch(new PlanActions.Remove(id)); //This seems silly
this.store.dispatch(new PlanActions.Load(id));
return of(this.plan$);
}
reducer:
case PlanActionTypes.LoadSuccess: {
return adapter.addOne(action.payload, {
...state,
selectedPlanId: state.selectedPlanId,
});
}
case PlanActionTypes.Load: {
return {
...state,
selectedPlanId: action.payload,
};
}
Effect:
@Effect()
loadPlan$: Observable<Action> = this.actions$
.ofType<Load>(PlanActionTypes.Load).pipe(
switchMap(action => this.planService.getPlan(action.payload)),
map((plan: Plan) => new LoadSuccess(plan)),
catchError(err => {
toastr.error(`Could not load plan.`);
console.error(err);
return of(new LoadFail(err));
})
);
Action:
export class Load implements Action {
readonly type = PlanActionTypes.Load;
constructor(public payload: number) {}
}
export class LoadSuccess implements Action {
readonly type = PlanActionTypes.LoadSuccess;
constructor(public payload: Plan) {}
}
export class LoadFail implements Action {
readonly type = PlanActionTypes.LoadFail;
constructor(public payload: any) {}
}
EDIT:
So Im getting
Plan{
a: Value
b: value
c - z: null
}
and I'm expecting
Plan{
a:value
....
z: value
}
By removing first i get the expected result.
angular typescript ngrx-store
angular typescript ngrx-store
asked Nov 14 '18 at 3:02
SethSeth
3201220
asked Nov 14 '18 at 3:02
SethSeth
3201220
edited Nov 14 '18 at 4:32
Seth
asked Nov 14 '18 at 3:02
SethSeth
3201220
asked Nov 14 '18 at 3:02
SethSeth
3201220
asked Nov 14 '18 at 3:02
SethSeth
3201220
3201220
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53292582%2fgetting-new-data-from-effect-reducer-action-pattern%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53292582%2fgetting-new-data-from-effect-reducer-action-pattern%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
