Wsrtjtyk

I have angular 6 project. And I was using ngModel and formControlName together. But angular gave me warning in below. Forexamle when I open update popup from button in grid, I can easily bind inputs in update popup automatically. But angular 7 says that remove ngModel. So, I must always map everything to my student object. What is the best way for this? Can we give formValueType to form value like studentObject in below code and then can it bind automatically?

Angular warning:

     It looks like you're using ngModel on the same form field 

as formControlName. Support for using the ngModel input property and 

ngModelChange event with reactive form directives has been deprecated

 in Angular v6 and will be removed in Angular v7.

myHtml

<form [formGroup]="studentForm" ??????formValueType="studentObject"?????>

  <p-dialog>

    <div class="ui-g-12 form-group">

      <div class="ui-g-4">

        <label>Name Surname</label>

      </div>

      <div class="ui-g-8">

        <input pInputText [(ngModel)]="selectedStudent.nameSurname"  formControlName="nameSurname" />

      </div>

    </div>

    <div class="ui-g-12 form-group">

      <div class="ui-g-4">

        <label>Email</label>

      </div>

      <div class="ui-g-8">

        <input pInputText [(ngModel)]="selectedStudent.email" formControlName="email" />

      </div>

    </div>

        <div class="ui-g-12 form-group">

          <div class="ui-g-4">

            <label>Age</label>

          </div>

          <div class="ui-g-8">

            <input pInputText [(ngModel)]="selectedStudent.age"  formControlName="age" />

          </div>

        </div>

      </div>

    <button type="button" pButton icon="fa fa-check" (click)="save()" label="Save"></button>

  </p-dialog>

</form>

You just choose either ngModel with mean you are using template driven form or formControlName with mean you are using reactive form.
https://angular.io/guide/reactive-forms
If you want a simple form just remove formControlName in every input.
If you want to do more in form you can use reactive form by remove ngModel and add
name attribute like name=nameSurname

There is no need to use both (ngModel and formControlName)

While Update you can use reactive form using

 patchValue(value: {...}, options: {...}): void

https://angular.io/api/forms/FormGroup

For your case you will need something like

this.studentForm.patchValue({

  nameSurname : 'Some Name',

  email : 'example@email.com,

  age : '24'

})

This will pre-fill the value to the form and you can easily use same form for update

Having ngModel with formGroup is really odd. You should remove ngModel and instead bind on valueChanges on fromGroup and then just iterate through received data and assign values.

 //somewhere where form is build

 this.studentForm.valueChanges.subscribe(data => this.onStudentFormValueChange(data));



 private onStudentFormValueChange(data) {

    this.selectedStudent.age = data.age

    this.selectedStudent.email = data.email

    this.selectedStudent.nameSurname = data.nameSurname



    // or

    for (const key in this.studentForm.controls) {

       const control = this.studentForm.get(key);

       this.selectedStudent[key] = control.value

    }

}

The best way is to use ReactiveForms with formGroup and formControlName. If you want to make it automatic, maybe you can parse your object and for each element you create a new parameter using the element key. Then you can patch the formGroup with your object.