Wsrtjtyk

This is my whole code....
I am facing the problem while replacing the %20 with - in url. I have tried many codes but failed. please help me out. I am attaching my full code. I am getting problem in

/">Visit

where i am displaying both id as well as firm name. I just want to show both id as well as firm name and they are separated by /

<?php 

error_reporting("0");

 $rowperpage =10 ;

@$select_city=$_GET['city'];

if(isset($_REQUEST['search'])){



 $allcount_query = "SELECT count(*) as allcount FROM inventory_details";



            $allcount_result = mysqli_query($conn, $allcount_query);

            $allcount_fetch = mysqli_fetch_array($allcount_result);

            $allcount = $allcount_fetch['allcount'];



 $sql="SELECT * FROM inventory_details";





   $search_item = mysqli_real_escape_string($conn, $_REQUEST['search_box']);



   $sql .= " WHERE (firm_name LIKE '%$search_item%'";

    $sql .= " OR catagory_name LIKE'%$search_item%'";

    $sql .= " OR mobile_no LIKE'%$search_item%'";

      $sql .= " OR product_key LIKE'%$search_item%')";

       $sql .= " AND city='$select_city' AND status='0' ";

       $sql .="ORDER BY today_date DESC limit 0,$rowperpage";



       // $sql .=  " ORDER BY catagory_name LIMIT 0,5";

       // echo $sql;

     if($_GET['search_box']==""){

      $msg=include"error_msg.php";

     }



   else{

     $fquery=mysqli_query($conn, $sql); 

     $totalrec=mysqli_num_rows($fquery);



   if ($totalrec=='0'){

    $msg=include"error_msg.php";

   }

   }



}

//   if($selct_city=$_GET['city']){

// SELECT * FROM inventory_details WHERE city LIKE '%DELHI%' && catagory_name LIKE '%belts%'

//    SELECT * FROM inventory_details WHERE firm_name='keyboard' OR catagory_name='keyboard' OR mobile_no='keyboard' OR city='keyboard' OR product_key='keyboard' && city="delhi"

//   echo $sql . $fquery;

// SELECT * FROM inventory_details WHERE city='delhi' AND catagory_name like '%foot%' OR firm_name LIKE'%foot%' OR product_key like '%foot%' OR mobile_no like '%foot%'

// SELECT * FROM inventory_details WHERE city='Delhi' AND firm_name LIKE '%foot%' OR catagory_name LIKE'%foot%' OR mobile_no LIKE'%foot%' OR product_key LIKE'%foot%'

// // }



 ?>

<?php 



?>





  <!-- Brand and toggle get grouped for better mobile display -->

<!--    <div class="container">

    <form class="navbar-form" role="search">

        <div class="input-group col-md-12 col-xs-12  ">

           <div class=" col-md-offset-7 col-md-5">



           <select class="form-control  select country" name="city" required="">please select city

                             <?php ;?>

                 </select>

              <select class="form-control input-lg" placeholder="Search By Firm name,Category name,Mobile no....." name="search_box">

              <option>select city</option>

              <option>Delhi</option>

              <option>Mumbai</option>

              <option>Channai</option>

              <option>Kolkata</option>

              </select>

            </div>

            <div class="input-group-btn ">



            </div>

            <div class=" col-md-12">

            <input type="text" class="form-control" placeholder="Just Type Anything..." name="search_box">

            </div>

            <div class="input-group-btn ">

                <a href="catagory.php"><button class="btn btn-info" type="submit" name="search"><span class=""></span>search</button></a>

            </div>

        </div>

        </form>

        </div> -->

 <?php 



   while($row=mysqli_fetch_assoc(@$fquery)){  //handle rows.



      $id=$row['id'];

     $catagory_name=$row['catagory_name'];

     $firm_name=$row['firm_name'];

   // $user_pass=md5($_POST ['user_pass']);

     $city=$row ['city'];

      $product_key=$row ['product_key'];

      $firm_email=$row ['firm_email'];

      $mobile_no=$row ['mobile_no'];

      $phone_no=$row ['phone_no'];

      $address=$row ['address'];

      $Fax_no=$row ['Fax_no'];

      $Website=$row ['Website'];

      $product_key=$row['product_key'];

       $sotime=$row ['sotime'];

      $sctime=$row ['sctime'];

      $Contact_person=$row ['Contact_person'];

      $Contact_person_mobile=$row ['Contact_person_mobile'];

      $colorname=$row ['colorname'];

      $textcolor=$row ['textcolor'];



      $compLogo=$row ['compLogo'];



      ////////////////////////////////////////

      $banner=$row ['banner'];

     if(empty($banner))

     {

    $banner="default.jpg"; 

     }

?>



<div class="container post" id="post_<?php echo $id; ?>">



 <div class="col-md-12 inv_data" style="background:<?php echo $colorname; ?>; color:<?php echo $textcolor; ?>;">



 <div class="col-md-3">

 <!-- <?php  ?>

   <img src="image/banner/<?php echo $banner; ?>" class="img_style"> -->

   <?php



       $imageArr = explode(',',$compLogo);

       foreach ($imageArr as $k=>$val) { if($val!=""){

     ?>



    <img class="mySlides" src="image/logo/<?php echo $val; ?>">

     <?php

   }}

     ?>

  <img class="mySlides" src="image/logo/defualt.jpg">

</div>



  <div class="col-md-7">

    <h3><strong><?php echo strtoupper($firm_name); ?></strong></h3>

      <strong></strong> <?php echo $product_key; ?><br>

          <strong> <span class="glyphicon glyphicon-home"></span> </strong> <?php echo $address; ?><br>

         <!--  <strong>Category : -</strong> <?php echo $catagory_name." , " . $product_key;?><br> -->

          <!-- <strong>Phone no : -</strong> <?php echo $phone_no; ?>&nbsp;

          <strong>Mobile no : -</strong> <?php echo $mobile_no; ?>&nbsp;



          <br>

        <strong> Whatsapp no : -</strong> <?php echo $Contact_person_mobile ; ?>&nbsp;

        <strong> Contact Person : -</strong> <?php echo $Contact_person ; ?>&nbsp;



        <br>

          <strong>Email : -</strong> <?php echo $firm_email;?>&nbsp;

          <strong>Timing : -</strong> <?php echo $sotime. " to ".$sctime?><br>



          <strong>Website : -</strong> <?php echo $Website;?><br> -->

  </div>

  <div class="col-md-2">

  <span>&nbsp;<br>&nbsp;<br>&nbsp;<br></span>

   <a href="category.php?edit=<?php echo $id;?>/<?php echo $firm_name;?>"><button type="button" class="btn btn-info btn-lg">Visit</button></a> 



   <!--<a href="/jyp/<?php echo $id;?><?php echo $firm_name;?>"><button type="button" class="btn btn-info btn-lg">Visit</button>-->

   </a>

  </div>



 </div>

</div>

 <?php



}



 ?>

  <?php 

  if(isset($_REQUEST['search'])){

    ?>



  <h1 id="loadbtn"><span class="load-more">Load More</span></h1>

    <input type="hidden" id="row" value="0">

   <input type="hidden" id="cityname"  name="cityname" value="<?php echo  $city; ?>">

   <input type="hidden" id="search_item"  name="search_item" value="<?php echo $search_item; ?>">

    <input type="hidden" id="all" value="<?php echo $allcount; ?>">



    <?php

      }

    ?>

The %20 gives a hint that the string is most probably Url Encoded (%20 is a single space character). So what you should probably be doing is trying to first Url Decode the string (then you will get the original string). Then afterwards you can remove/replace any characters that you do not want.

So in your question, you said you do not want %20 (a space) but a dash (-) instead. This could be achieved as follows...

  <?php 

    error_reporting("0");

     $rowperpage =10 ;

    @$select_city=$_GET['city'];

    if(isset($_REQUEST['search'])){



     $allcount_query = "SELECT count(*) as allcount FROM inventory_details";



                $allcount_result = mysqli_query($conn, $allcount_query);

                $allcount_fetch = mysqli_fetch_array($allcount_result);

                $allcount = $allcount_fetch['allcount'];



     $sql="SELECT * FROM inventory_details";





       $search_item = mysqli_real_escape_string($conn, $_REQUEST['search_box']);



       $sql .= " WHERE (firm_name LIKE '%$search_item%'";

        $sql .= " OR catagory_name LIKE'%$search_item%'";

        $sql .= " OR mobile_no LIKE'%$search_item%'";

          $sql .= " OR product_key LIKE'%$search_item%')";

           $sql .= " AND city='$select_city' AND status='0' ";

           $sql .="ORDER BY today_date DESC limit 0,$rowperpage";



           // $sql .=  " ORDER BY catagory_name LIMIT 0,5";

           // echo $sql;

         if($_GET['search_box']==""){

          $msg=include"error_msg.php";

         }



       else{

         $fquery=mysqli_query($conn, $sql); 

         $totalrec=mysqli_num_rows($fquery);



       if ($totalrec=='0'){

        $msg=include"error_msg.php";

       }

       }



    }

    //   if($selct_city=$_GET['city']){

    // SELECT * FROM inventory_details WHERE city LIKE '%DELHI%' && catagory_name LIKE '%belts%'

    //    SELECT * FROM inventory_details WHERE firm_name='keyboard' OR catagory_name='keyboard' OR mobile_no='keyboard' OR city='keyboard' OR product_key='keyboard' && city="delhi"

    //   echo $sql . $fquery;

    // SELECT * FROM inventory_details WHERE city='delhi' AND catagory_name like '%foot%' OR firm_name LIKE'%foot%' OR product_key like '%foot%' OR mobile_no like '%foot%'

    // SELECT * FROM inventory_details WHERE city='Delhi' AND firm_name LIKE '%foot%' OR catagory_name LIKE'%foot%' OR mobile_no LIKE'%foot%' OR product_key LIKE'%foot%'

    // // }



     ?>

    <?php 



    ?>





      <!-- Brand and toggle get grouped for better mobile display -->

    <!--    <div class="container">

        <form class="navbar-form" role="search">

            <div class="input-group col-md-12 col-xs-12  ">

               <div class=" col-md-offset-7 col-md-5">



               <select class="form-control  select country" name="city" required="">please select city

                                 <?php ;?>

                     </select>

                  <select class="form-control input-lg" placeholder="Search By Firm name,Category name,Mobile no....." name="search_box">

                  <option>select city</option>

                  <option>Delhi</option>

                  <option>Mumbai</option>

                  <option>Channai</option>

                  <option>Kolkata</option>

                  </select>

                </div>

                <div class="input-group-btn ">



                </div>

                <div class=" col-md-12">

                <input type="text" class="form-control" placeholder="Just Type Anything..." name="search_box">

                </div>

                <div class="input-group-btn ">

                    <a href="catagory.php"><button class="btn btn-info" type="submit" name="search"><span class=""></span>search</button></a>

                </div>

            </div>

            </form>

            </div> -->

     <?php 



       while($row=mysqli_fetch_assoc(@$fquery)){  //handle rows.



          $id=$row['id'];

         $catagory_name=$row['catagory_name'];

         $firm_name=$row['firm_name'];

       // $user_pass=md5($_POST ['user_pass']);

         $city=$row ['city'];

          $product_key=$row ['product_key'];

          $firm_email=$row ['firm_email'];

          $mobile_no=$row ['mobile_no'];

          $phone_no=$row ['phone_no'];

          $address=$row ['address'];

          $Fax_no=$row ['Fax_no'];

          $Website=$row ['Website'];

          $product_key=$row['product_key'];

           $sotime=$row ['sotime'];

          $sctime=$row ['sctime'];

          $Contact_person=$row ['Contact_person'];

          $Contact_person_mobile=$row ['Contact_person_mobile'];

          $colorname=$row ['colorname'];

          $textcolor=$row ['textcolor'];



          $compLogo=$row ['compLogo'];



          ////////////////////////////////////////

          $banner=$row ['banner'];

         if(empty($banner))

         {

        $banner="default.jpg"; 

         }

    ?>



    <div class="container post" id="post_<?php echo $id; ?>">



     <div class="col-md-12 inv_data" style="background:<?php echo $colorname; ?>; color:<?php echo $textcolor; ?>;">



     <div class="col-md-3">

     <!-- <?php  ?>

       <img src="image/banner/<?php echo $banner; ?>" class="img_style"> -->

       <?php



           $imageArr = explode(',',$compLogo);

           foreach ($imageArr as $k=>$val) { if($val!=""){

         ?>



        <img class="mySlides" src="image/logo/<?php echo $val; ?>">

         <?php

       }}

         ?>

      <img class="mySlides" src="image/logo/defualt.jpg">

    </div>



      <div class="col-md-7">

        <h3><strong><?php echo strtoupper($firm_name); ?></strong></h3>

          <strong></strong> <?php echo $product_key; ?><br>

              <strong> <span class="glyphicon glyphicon-home"></span> </strong> <?php echo $address; ?><br>

             <!--  <strong>Category : -</strong> <?php echo $catagory_name." , " . $product_key;?><br> -->

              <!-- <strong>Phone no : -</strong> <?php echo $phone_no; ?>&nbsp;

              <strong>Mobile no : -</strong> <?php echo $mobile_no; ?>&nbsp;



              <br>

            <strong> Whatsapp no : -</strong> <?php echo $Contact_person_mobile ; ?>&nbsp;

            <strong> Contact Person : -</strong> <?php echo $Contact_person ; ?>&nbsp;



            <br>

              <strong>Email : -</strong> <?php echo $firm_email;?>&nbsp;

              <strong>Timing : -</strong> <?php echo $sotime. " to ".$sctime?><br>



              <strong>Website : -</strong> <?php echo $Website;?><br> -->

      </div>

      <div class="col-md-2">

      <span>&nbsp;<br>&nbsp;<br>&nbsp;<br></span>





       <!-- there's the solution below -->



       <?php

            $firm_name = urldecode($firm_name);    # decode the string (like converting %20 to a space character)

            $firm_name = str_replace(' ', '-', $firm_name);    # then replace any characters you don't want (like converting a space character to a -

            $url = "category.php?edit=" . urlencode($id) . '/' . urlencode($firm_name);

       ?>



       <a href="<?php echo $url ?>"><button type="button" class="btn btn-info btn-lg">Visit</button></a> 



       <?php

        // probably don't need these now.

        $firm_name = urldecode($firm_name);  

        $firm_name = str_replace(' ', '-', $firm_name); 



                        # are you missing a / here ???

        $url = '/jyp/' . urlencode($id) . '' . urlencode($firm_name);

   ?>



   <a href="<?php echo $url ?>"><button type="button" class="btn btn-info btn-lg">Visit</button>

   </a>

      </div>



     </div>

    </div>

     <?php



    }



     ?>

      <?php 

      if(isset($_REQUEST['search'])){

        ?>



      <h1 id="loadbtn"><span class="load-more">Load More</span></h1>

        <input type="hidden" id="row" value="0">

       <input type="hidden" id="cityname"  name="cityname" value="<?php echo  $city; ?>">

       <input type="hidden" id="search_item"  name="search_item" value="<?php echo $search_item; ?>">

        <input type="hidden" id="all" value="<?php echo $allcount; ?>">



        <?php

          }

        ?>

You probably should encode whatever you echo to the browser using htmlspecialchars.

Disclaimer: The website where I was testing my PHP code gave the same result when using rawurldecode('hi%20you'); and urldecode('hi%20you');.