Is there a way a more efficient way to write the IF statement












1














Is the there a more efficient way to write the below IF statement so I only need 2 lines of code or can this be solved with a ternary operator ?



        if(postIds.size()>0) {
PostProperty(postIds);
}
if(putIds.size()>0) {
PutProperty(putIds);
}









share|improve this question



























    1














    Is the there a more efficient way to write the below IF statement so I only need 2 lines of code or can this be solved with a ternary operator ?



            if(postIds.size()>0) {
    PostProperty(postIds);
    }
    if(putIds.size()>0) {
    PutProperty(putIds);
    }









    share|improve this question

























      1












      1








      1







      Is the there a more efficient way to write the below IF statement so I only need 2 lines of code or can this be solved with a ternary operator ?



              if(postIds.size()>0) {
      PostProperty(postIds);
      }
      if(putIds.size()>0) {
      PutProperty(putIds);
      }









      share|improve this question













      Is the there a more efficient way to write the below IF statement so I only need 2 lines of code or can this be solved with a ternary operator ?



              if(postIds.size()>0) {
      PostProperty(postIds);
      }
      if(putIds.size()>0) {
      PutProperty(putIds);
      }






      apex list conditional if






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 10 at 10:57









      Thomas

      633213




      633213






















          1 Answer
          1






          active

          oldest

          votes


















          4














          We use the coding convention that the curly brackets can be skipped if the condition is placed on a single line to make these common cases less cluttered looking. (Such conventions generally cause great debate though.)



          So in your case it would be:



          if (postIds.size() > 0) PostProperty(postIds);
          if (putIds.size() > 0) PutProperty(putIds);


          Your logic has 4 outcomes so a simple ternary if won't work as that only has 2 outcomes; ternary if is really for methods that return a value that is to be assigned to a variable.



          Guards like those could be put inside the methods, particularly if the methods are called from several places. Then the calling code reads more cleanly.



          If by "efficiency" you are thinking about execution speed then don't: making it easy for people to understand what the code is doing is the most important thing most of the time.






          share|improve this answer























            Your Answer








            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "459"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fsalesforce.stackexchange.com%2fquestions%2f238938%2fis-there-a-way-a-more-efficient-way-to-write-the-if-statement%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            4














            We use the coding convention that the curly brackets can be skipped if the condition is placed on a single line to make these common cases less cluttered looking. (Such conventions generally cause great debate though.)



            So in your case it would be:



            if (postIds.size() > 0) PostProperty(postIds);
            if (putIds.size() > 0) PutProperty(putIds);


            Your logic has 4 outcomes so a simple ternary if won't work as that only has 2 outcomes; ternary if is really for methods that return a value that is to be assigned to a variable.



            Guards like those could be put inside the methods, particularly if the methods are called from several places. Then the calling code reads more cleanly.



            If by "efficiency" you are thinking about execution speed then don't: making it easy for people to understand what the code is doing is the most important thing most of the time.






            share|improve this answer




























              4














              We use the coding convention that the curly brackets can be skipped if the condition is placed on a single line to make these common cases less cluttered looking. (Such conventions generally cause great debate though.)



              So in your case it would be:



              if (postIds.size() > 0) PostProperty(postIds);
              if (putIds.size() > 0) PutProperty(putIds);


              Your logic has 4 outcomes so a simple ternary if won't work as that only has 2 outcomes; ternary if is really for methods that return a value that is to be assigned to a variable.



              Guards like those could be put inside the methods, particularly if the methods are called from several places. Then the calling code reads more cleanly.



              If by "efficiency" you are thinking about execution speed then don't: making it easy for people to understand what the code is doing is the most important thing most of the time.






              share|improve this answer


























                4












                4








                4






                We use the coding convention that the curly brackets can be skipped if the condition is placed on a single line to make these common cases less cluttered looking. (Such conventions generally cause great debate though.)



                So in your case it would be:



                if (postIds.size() > 0) PostProperty(postIds);
                if (putIds.size() > 0) PutProperty(putIds);


                Your logic has 4 outcomes so a simple ternary if won't work as that only has 2 outcomes; ternary if is really for methods that return a value that is to be assigned to a variable.



                Guards like those could be put inside the methods, particularly if the methods are called from several places. Then the calling code reads more cleanly.



                If by "efficiency" you are thinking about execution speed then don't: making it easy for people to understand what the code is doing is the most important thing most of the time.






                share|improve this answer














                We use the coding convention that the curly brackets can be skipped if the condition is placed on a single line to make these common cases less cluttered looking. (Such conventions generally cause great debate though.)



                So in your case it would be:



                if (postIds.size() > 0) PostProperty(postIds);
                if (putIds.size() > 0) PutProperty(putIds);


                Your logic has 4 outcomes so a simple ternary if won't work as that only has 2 outcomes; ternary if is really for methods that return a value that is to be assigned to a variable.



                Guards like those could be put inside the methods, particularly if the methods are called from several places. Then the calling code reads more cleanly.



                If by "efficiency" you are thinking about execution speed then don't: making it easy for people to understand what the code is doing is the most important thing most of the time.







                share|improve this answer














                share|improve this answer



                share|improve this answer








                edited Nov 10 at 11:17

























                answered Nov 10 at 11:05









                Keith C

                94.1k1089201




                94.1k1089201






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Salesforce Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fsalesforce.stackexchange.com%2fquestions%2f238938%2fis-there-a-way-a-more-efficient-way-to-write-the-if-statement%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    這個網誌中的熱門文章

                    Xamarin.form Move up view when keyboard appear

                    Post-Redirect-Get with Spring WebFlux and Thymeleaf

                    Anylogic : not able to use stopDelay()