Sequelize Include doesn't work without results












0















I'm doing the select below and it works great when it has results to return, when I it doesn't i have an error like this




TypeError: Cannot read property 'id' of null




This only occcurs when they city doesn't have any marker, otherwise it works as expected. Did anyone have this problem? The error occurs with or wihout where clause



            City.findById(req.params.id,{
include: [{ model: Marker, as: "markers",
where: {
status: '1'
},
}]
}).then(city =>{
console.log(city.id);
res.status(201).send(city);
}) .catch(error => {
console.log(error);
res.status(400).send(error)
});


City



            module.exports = (sequelize, DataTypes) => {
const City = sequelize.define('city', {
name: { type: DataTypes.STRING, allowNull: false },
status: { type: DataTypes.INTEGER, allowNull: false },
latitude: { type: DataTypes.DECIMAL, allowNull: false },
longitude: { type: DataTypes.DECIMAL, allowNull: false },

}, { freezeTableName: true});
City.associate = function(models) {
// associations can be defined here
City.hasMany(models.marker,{as: 'markers', foreignKey: 'cityId'})
};
return City;
};


Marker



            module.exports = (sequelize, DataTypes) => {
const Marker = sequelize.define('marker', {
description: { type: DataTypes.STRING, allowNull: false },
status: { type: DataTypes.INTEGER, allowNull: false },
latitude: { type: DataTypes.DECIMAL, allowNull: false },
longitude: { type: DataTypes.DECIMAL, allowNull: false },
cityId: {
type: DataTypes.INTEGER,
references: {
model: 'city',
key: 'id',
},
allowNull: false,
}

}, { freezeTableName: true});
Marker.associate = function(models) {
// associations can be defined here
};
return Marker;
};


query logged.



Executing (default): SELECT "city"."id", "city"."name", "city"."status", "city".
"latitude", "city"."longitude", "city"."createdAt", "city"."updatedAt", "markers
"."id" AS "markers.id", "markers"."description" AS "markers.description", "marke
rs"."status" AS "markers.status", "markers"."latitude" AS "markers.latitude", "m
arkers"."longitude" AS "markers.longitude", "markers"."cityId" AS "markers.cityI
d", "markers"."createdAt" AS "markers.createdAt", "markers"."updatedAt" AS "mark
ers.updatedAt" FROM "city" AS "city" INNER JOIN "marker" AS "markers" ON "city".
"id" = "markers"."cityId" AND "markers"."status" = '1' WHERE "city"."id" = '4';









share|improve this question





























    0















    I'm doing the select below and it works great when it has results to return, when I it doesn't i have an error like this




    TypeError: Cannot read property 'id' of null




    This only occcurs when they city doesn't have any marker, otherwise it works as expected. Did anyone have this problem? The error occurs with or wihout where clause



                City.findById(req.params.id,{
    include: [{ model: Marker, as: "markers",
    where: {
    status: '1'
    },
    }]
    }).then(city =>{
    console.log(city.id);
    res.status(201).send(city);
    }) .catch(error => {
    console.log(error);
    res.status(400).send(error)
    });


    City



                module.exports = (sequelize, DataTypes) => {
    const City = sequelize.define('city', {
    name: { type: DataTypes.STRING, allowNull: false },
    status: { type: DataTypes.INTEGER, allowNull: false },
    latitude: { type: DataTypes.DECIMAL, allowNull: false },
    longitude: { type: DataTypes.DECIMAL, allowNull: false },

    }, { freezeTableName: true});
    City.associate = function(models) {
    // associations can be defined here
    City.hasMany(models.marker,{as: 'markers', foreignKey: 'cityId'})
    };
    return City;
    };


    Marker



                module.exports = (sequelize, DataTypes) => {
    const Marker = sequelize.define('marker', {
    description: { type: DataTypes.STRING, allowNull: false },
    status: { type: DataTypes.INTEGER, allowNull: false },
    latitude: { type: DataTypes.DECIMAL, allowNull: false },
    longitude: { type: DataTypes.DECIMAL, allowNull: false },
    cityId: {
    type: DataTypes.INTEGER,
    references: {
    model: 'city',
    key: 'id',
    },
    allowNull: false,
    }

    }, { freezeTableName: true});
    Marker.associate = function(models) {
    // associations can be defined here
    };
    return Marker;
    };


    query logged.



    Executing (default): SELECT "city"."id", "city"."name", "city"."status", "city".
    "latitude", "city"."longitude", "city"."createdAt", "city"."updatedAt", "markers
    "."id" AS "markers.id", "markers"."description" AS "markers.description", "marke
    rs"."status" AS "markers.status", "markers"."latitude" AS "markers.latitude", "m
    arkers"."longitude" AS "markers.longitude", "markers"."cityId" AS "markers.cityI
    d", "markers"."createdAt" AS "markers.createdAt", "markers"."updatedAt" AS "mark
    ers.updatedAt" FROM "city" AS "city" INNER JOIN "marker" AS "markers" ON "city".
    "id" = "markers"."cityId" AND "markers"."status" = '1' WHERE "city"."id" = '4';









    share|improve this question



























      0












      0








      0








      I'm doing the select below and it works great when it has results to return, when I it doesn't i have an error like this




      TypeError: Cannot read property 'id' of null




      This only occcurs when they city doesn't have any marker, otherwise it works as expected. Did anyone have this problem? The error occurs with or wihout where clause



                  City.findById(req.params.id,{
      include: [{ model: Marker, as: "markers",
      where: {
      status: '1'
      },
      }]
      }).then(city =>{
      console.log(city.id);
      res.status(201).send(city);
      }) .catch(error => {
      console.log(error);
      res.status(400).send(error)
      });


      City



                  module.exports = (sequelize, DataTypes) => {
      const City = sequelize.define('city', {
      name: { type: DataTypes.STRING, allowNull: false },
      status: { type: DataTypes.INTEGER, allowNull: false },
      latitude: { type: DataTypes.DECIMAL, allowNull: false },
      longitude: { type: DataTypes.DECIMAL, allowNull: false },

      }, { freezeTableName: true});
      City.associate = function(models) {
      // associations can be defined here
      City.hasMany(models.marker,{as: 'markers', foreignKey: 'cityId'})
      };
      return City;
      };


      Marker



                  module.exports = (sequelize, DataTypes) => {
      const Marker = sequelize.define('marker', {
      description: { type: DataTypes.STRING, allowNull: false },
      status: { type: DataTypes.INTEGER, allowNull: false },
      latitude: { type: DataTypes.DECIMAL, allowNull: false },
      longitude: { type: DataTypes.DECIMAL, allowNull: false },
      cityId: {
      type: DataTypes.INTEGER,
      references: {
      model: 'city',
      key: 'id',
      },
      allowNull: false,
      }

      }, { freezeTableName: true});
      Marker.associate = function(models) {
      // associations can be defined here
      };
      return Marker;
      };


      query logged.



      Executing (default): SELECT "city"."id", "city"."name", "city"."status", "city".
      "latitude", "city"."longitude", "city"."createdAt", "city"."updatedAt", "markers
      "."id" AS "markers.id", "markers"."description" AS "markers.description", "marke
      rs"."status" AS "markers.status", "markers"."latitude" AS "markers.latitude", "m
      arkers"."longitude" AS "markers.longitude", "markers"."cityId" AS "markers.cityI
      d", "markers"."createdAt" AS "markers.createdAt", "markers"."updatedAt" AS "mark
      ers.updatedAt" FROM "city" AS "city" INNER JOIN "marker" AS "markers" ON "city".
      "id" = "markers"."cityId" AND "markers"."status" = '1' WHERE "city"."id" = '4';









      share|improve this question
















      I'm doing the select below and it works great when it has results to return, when I it doesn't i have an error like this




      TypeError: Cannot read property 'id' of null




      This only occcurs when they city doesn't have any marker, otherwise it works as expected. Did anyone have this problem? The error occurs with or wihout where clause



                  City.findById(req.params.id,{
      include: [{ model: Marker, as: "markers",
      where: {
      status: '1'
      },
      }]
      }).then(city =>{
      console.log(city.id);
      res.status(201).send(city);
      }) .catch(error => {
      console.log(error);
      res.status(400).send(error)
      });


      City



                  module.exports = (sequelize, DataTypes) => {
      const City = sequelize.define('city', {
      name: { type: DataTypes.STRING, allowNull: false },
      status: { type: DataTypes.INTEGER, allowNull: false },
      latitude: { type: DataTypes.DECIMAL, allowNull: false },
      longitude: { type: DataTypes.DECIMAL, allowNull: false },

      }, { freezeTableName: true});
      City.associate = function(models) {
      // associations can be defined here
      City.hasMany(models.marker,{as: 'markers', foreignKey: 'cityId'})
      };
      return City;
      };


      Marker



                  module.exports = (sequelize, DataTypes) => {
      const Marker = sequelize.define('marker', {
      description: { type: DataTypes.STRING, allowNull: false },
      status: { type: DataTypes.INTEGER, allowNull: false },
      latitude: { type: DataTypes.DECIMAL, allowNull: false },
      longitude: { type: DataTypes.DECIMAL, allowNull: false },
      cityId: {
      type: DataTypes.INTEGER,
      references: {
      model: 'city',
      key: 'id',
      },
      allowNull: false,
      }

      }, { freezeTableName: true});
      Marker.associate = function(models) {
      // associations can be defined here
      };
      return Marker;
      };


      query logged.



      Executing (default): SELECT "city"."id", "city"."name", "city"."status", "city".
      "latitude", "city"."longitude", "city"."createdAt", "city"."updatedAt", "markers
      "."id" AS "markers.id", "markers"."description" AS "markers.description", "marke
      rs"."status" AS "markers.status", "markers"."latitude" AS "markers.latitude", "m
      arkers"."longitude" AS "markers.longitude", "markers"."cityId" AS "markers.cityI
      d", "markers"."createdAt" AS "markers.createdAt", "markers"."updatedAt" AS "mark
      ers.updatedAt" FROM "city" AS "city" INNER JOIN "marker" AS "markers" ON "city".
      "id" = "markers"."cityId" AND "markers"."status" = '1' WHERE "city"."id" = '4';






      postgresql typescript sequelize.js sequelize-cli






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 13 '18 at 11:50







      John

















      asked Nov 13 '18 at 11:44









      JohnJohn

      1971425




      1971425
























          1 Answer
          1






          active

          oldest

          votes


















          1














          It's because of this line:



          console.log(city.id);


          When city is null, which happens when the query doesn't match any documents in the database, your code evaluates to null.id, which is invalid, hence the error.






          share|improve this answer
























          • You are right, my mistake!

            – John
            Nov 13 '18 at 13:15











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53280332%2fsequelize-include-doesnt-work-without-results%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          1














          It's because of this line:



          console.log(city.id);


          When city is null, which happens when the query doesn't match any documents in the database, your code evaluates to null.id, which is invalid, hence the error.






          share|improve this answer
























          • You are right, my mistake!

            – John
            Nov 13 '18 at 13:15
















          1














          It's because of this line:



          console.log(city.id);


          When city is null, which happens when the query doesn't match any documents in the database, your code evaluates to null.id, which is invalid, hence the error.






          share|improve this answer
























          • You are right, my mistake!

            – John
            Nov 13 '18 at 13:15














          1












          1








          1







          It's because of this line:



          console.log(city.id);


          When city is null, which happens when the query doesn't match any documents in the database, your code evaluates to null.id, which is invalid, hence the error.






          share|improve this answer













          It's because of this line:



          console.log(city.id);


          When city is null, which happens when the query doesn't match any documents in the database, your code evaluates to null.id, which is invalid, hence the error.







          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered Nov 13 '18 at 12:03









          robertkleprobertklep

          135k18234243




          135k18234243













          • You are right, my mistake!

            – John
            Nov 13 '18 at 13:15



















          • You are right, my mistake!

            – John
            Nov 13 '18 at 13:15

















          You are right, my mistake!

          – John
          Nov 13 '18 at 13:15





          You are right, my mistake!

          – John
          Nov 13 '18 at 13:15


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53280332%2fsequelize-include-doesnt-work-without-results%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          這個網誌中的熱門文章

          Tangent Lines Diagram Along Smooth Curve

          Yusuf al-Mu'taman ibn Hud

          Zucchini