spring rest controller last-modified on collections
Is there a best practice or common implementation for using If-Modified-Since/Last-Modified conditional requests on collections? I have implemented the following sample on a GET by ID endpoint:
@RequestMapping(method = { RequestMethod.GET }, value = "/myEntities/{id}")
public ResponseEntity<MyEntity> getById(HttpServletRequest request, @PathVariable("id") final UUID id)
throws Exception {
final String ifNotModified = request.getHeader(HttpHeaders.IF_MODIFIED_SINCE);
final MyEntity response = myEntityService.getById(id);
if (StringUtils.hasText(ifNotModified)
&& OffsetDateTime.parse(ifNotModified, AppConstants.formatter).isEqual(response.getUpdatedTime())) {
return ResponseEntity.status(HttpStatus.SC_NOT_MODIFIED)
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate()).build();
}
return ResponseEntity.ok()
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate())
.lastModified(response.getUpdatedTime().toInstant().toEpochMilli()).body(response);
}
Note: Disregard the cache control policy.
If I am to implement a GET ALL endpoint (returning List) for the same resource, and a hypothetically unbound response size, what would that look like? Is it even common practice to implement this mechanism on collections?
java spring last-modified if-modified-since
asked Nov 13 '18 at 1:04
chauvdchauvd
12
add a comment |
Is there a best practice or common implementation for using If-Modified-Since/Last-Modified conditional requests on collections? I have implemented the following sample on a GET by ID endpoint:
@RequestMapping(method = { RequestMethod.GET }, value = "/myEntities/{id}")
public ResponseEntity<MyEntity> getById(HttpServletRequest request, @PathVariable("id") final UUID id)
throws Exception {
final String ifNotModified = request.getHeader(HttpHeaders.IF_MODIFIED_SINCE);
final MyEntity response = myEntityService.getById(id);
if (StringUtils.hasText(ifNotModified)
&& OffsetDateTime.parse(ifNotModified, AppConstants.formatter).isEqual(response.getUpdatedTime())) {
return ResponseEntity.status(HttpStatus.SC_NOT_MODIFIED)
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate()).build();
}
return ResponseEntity.ok()
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate())
.lastModified(response.getUpdatedTime().toInstant().toEpochMilli()).body(response);
}
Note: Disregard the cache control policy.
If I am to implement a GET ALL endpoint (returning List) for the same resource, and a hypothetically unbound response size, what would that look like? Is it even common practice to implement this mechanism on collections?
java spring last-modified if-modified-since
asked Nov 13 '18 at 1:04
chauvdchauvd
12
add a comment |
Is there a best practice or common implementation for using If-Modified-Since/Last-Modified conditional requests on collections? I have implemented the following sample on a GET by ID endpoint:
@RequestMapping(method = { RequestMethod.GET }, value = "/myEntities/{id}")
public ResponseEntity<MyEntity> getById(HttpServletRequest request, @PathVariable("id") final UUID id)
throws Exception {
final String ifNotModified = request.getHeader(HttpHeaders.IF_MODIFIED_SINCE);
final MyEntity response = myEntityService.getById(id);
if (StringUtils.hasText(ifNotModified)
&& OffsetDateTime.parse(ifNotModified, AppConstants.formatter).isEqual(response.getUpdatedTime())) {
return ResponseEntity.status(HttpStatus.SC_NOT_MODIFIED)
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate()).build();
}
return ResponseEntity.ok()
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate())
.lastModified(response.getUpdatedTime().toInstant().toEpochMilli()).body(response);
}
Note: Disregard the cache control policy.
If I am to implement a GET ALL endpoint (returning List) for the same resource, and a hypothetically unbound response size, what would that look like? Is it even common practice to implement this mechanism on collections?
java spring last-modified if-modified-since
asked Nov 13 '18 at 1:04
chauvdchauvd
12
Is there a best practice or common implementation for using If-Modified-Since/Last-Modified conditional requests on collections? I have implemented the following sample on a GET by ID endpoint:
@RequestMapping(method = { RequestMethod.GET }, value = "/myEntities/{id}")
public ResponseEntity<MyEntity> getById(HttpServletRequest request, @PathVariable("id") final UUID id)
throws Exception {
final String ifNotModified = request.getHeader(HttpHeaders.IF_MODIFIED_SINCE);
final MyEntity response = myEntityService.getById(id);
if (StringUtils.hasText(ifNotModified)
&& OffsetDateTime.parse(ifNotModified, AppConstants.formatter).isEqual(response.getUpdatedTime())) {
return ResponseEntity.status(HttpStatus.SC_NOT_MODIFIED)
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate()).build();
}
return ResponseEntity.ok()
.cacheControl(CacheControl.maxAge(0, TimeUnit.SECONDS).cachePrivate().mustRevalidate())
.lastModified(response.getUpdatedTime().toInstant().toEpochMilli()).body(response);
}
Note: Disregard the cache control policy.
If I am to implement a GET ALL endpoint (returning List) for the same resource, and a hypothetically unbound response size, what would that look like? Is it even common practice to implement this mechanism on collections?
java spring last-modified if-modified-since
java spring last-modified if-modified-since
asked Nov 13 '18 at 1:04
chauvdchauvd
12
asked Nov 13 '18 at 1:04
chauvdchauvd
12
asked Nov 13 '18 at 1:04
chauvdchauvd
12
asked Nov 13 '18 at 1:04
chauvdchauvd
12
asked Nov 13 '18 at 1:04
chauvdchauvd
12
12
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53272291%2fspring-rest-controller-last-modified-on-collections%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53272291%2fspring-rest-controller-last-modified-on-collections%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
