Wsrtjtyk

I keep getting System.Data.OleDb.OleDbException: 'No value given for one or more required parameters.' but i am giving it a value as you can see in my code:

private void PopWeapSel(string read)

{

    string weapID = read;

    string weapDam = "";

    string weapPat = "";

    string weapHeat = "";

    string weapName = "";

    OleDbConnection dbConn = new System.Data.OleDb.OleDbConnection("Provider=Microsoft.ACE.OLEDB.12.0;Data Source=BHShooterProjectDB.accdb");

    string sql = "SELECT ItemWeaponType.WeaponID, ItemWeaponType.WeaponDamage, ItemWeaponType.WeaponPattern, ItemWeaponType.WeaponHeatValue, ItemWeaponType.WeaponCoolRate, ItemWeaponType.WeaponName FROM ItemWeaponType WHERE ItemWeaponTypeWeaponID = @PU;";

    OleDbCommand cmd = new OleDbCommand(sql, dbConn);

    foreach (string WeapID in weapID)

    {

        if (WeapID == "")

        {

            return;

        }

        cmd.Parameters.AddWithValue("@PU", WeapID); ///Problem Line

        dbConn.Open();

        OleDbDataReader reader = cmd.ExecuteReader();



        if (reader.Read())

        {

            weapDam = reader[1].ToString();

            weapPat = reader[2].ToString();

            weapHeat = reader[3].ToString();

            weapName = reader[4].ToString();

        }

        dbConn.Close();

        this.DGV_WS.Rows.Add(weapDam, weapPat, weapHeat, weapName);

    }

}

When i look at the locals in the locals in debug. WeapID has a value of "1" as it should. Have i missed something in terms of syntax?

Thanks!

Move your OleDbCommand cmd = new OleDbCommand(sql, dbConn); line inside the foreach statement.

You are using the same command over and over, and adding more parameters than the query has.