All code paths does not return the value?
Any idea what is the issue here i am getting error "Not all code paths return the value " ?
Also is there better way to write code using ES6 instead of using forEach?
main.ts
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
});
}
javascript arrays angular typescript
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
add a comment |
Any idea what is the issue here i am getting error "Not all code paths return the value " ?
Also is there better way to write code using ES6 instead of using forEach?
main.ts
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
});
}
javascript arrays angular typescript
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
add a comment |
Any idea what is the issue here i am getting error "Not all code paths return the value " ?
Also is there better way to write code using ES6 instead of using forEach?
main.ts
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
});
}
javascript arrays angular typescript
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
Any idea what is the issue here i am getting error "Not all code paths return the value " ?
Also is there better way to write code using ES6 instead of using forEach?
main.ts
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
});
}
javascript arrays angular typescript
javascript arrays angular typescript
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
asked Nov 16 '18 at 16:41
hussainhussain
1,44452154
1,44452154
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
You are only returning a value (a Promise) if one of your member entries matches. Not sure what you want to happen if no match, but you probably want to return a promise either way, so add return Promise.resolve() after the loop to handle that case:
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
return Promise.resolve();
});
}
Given what you've provided, there's nothing particularly wrong with using forEach here.
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53342070%2fall-code-paths-does-not-return-the-value%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You are only returning a value (a Promise) if one of your member entries matches. Not sure what you want to happen if no match, but you probably want to return a promise either way, so add return Promise.resolve() after the loop to handle that case:
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
return Promise.resolve();
});
}
Given what you've provided, there's nothing particularly wrong with using forEach here.
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
add a comment |
You are only returning a value (a Promise) if one of your member entries matches. Not sure what you want to happen if no match, but you probably want to return a promise either way, so add return Promise.resolve() after the loop to handle that case:
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
return Promise.resolve();
});
}
Given what you've provided, there's nothing particularly wrong with using forEach here.
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
add a comment |
You are only returning a value (a Promise) if one of your member entries matches. Not sure what you want to happen if no match, but you probably want to return a promise either way, so add return Promise.resolve() after the loop to handle that case:
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
return Promise.resolve();
});
}
Given what you've provided, there's nothing particularly wrong with using forEach here.
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
You are only returning a value (a Promise) if one of your member entries matches. Not sure what you want to happen if no match, but you probably want to return a promise either way, so add return Promise.resolve() after the loop to handle that case:
if (rxInfos.length && rxInfos !== undefined) {
rxInfos.forEach((rxInfo: any) => {
// const requestArray: IRequestURL = ;
for (const member of specialtyMembers) {
if (member.indexID === rxInfo.indexID) {
proxyMember = member;
if (!member.dateOfBirth) {
statusDesc = "member dateOfbirth not found";
return Promise.reject(this.errorHandler(request, statusDesc));
}
const body: any = this.buildSingleRequestBody(proxyMember, rxInfo);
const requestObject = this.specialtyQuestionRequest(body);
this.requestArray.push(requestObject);
break;
}
}
return Promise.resolve();
});
}
Given what you've provided, there's nothing particularly wrong with using forEach here.
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
edited Nov 16 '18 at 16:56
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
answered Nov 16 '18 at 16:51
Jim B.Jim B.
2,6621929
2,6621929
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
add a comment |
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
ok in that case if not member does not match i would send an error using Promise.reject(e) i think i got it
– hussain
Nov 16 '18 at 17:03
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
In that case you'd be reject no matter what, but I think you get the idea.
– Jim B.
Nov 16 '18 at 18:25
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53342070%2fall-code-paths-does-not-return-the-value%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
