TypeScript React SFC children props type error
I have the following stateless functional component defined:
import { SFC } from "react";
type ProfileTabContentProps = {
selected: boolean;
};
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) => selected && children;
This fails to compile with the following error:
Type '({ selected, children }: ProfileTabContentProps & { children?: ReactNode; }) => ReactNode' is not assignable to type 'StatelessComponent'.
Type 'ReactNode' is not assignable to type 'ReactElement | null'.
Type 'undefined' is not assignable to type 'ReactElement | null'.
A quick search for related questions all give the same answer, which is very similar to what I've done. What am I missing?
reactjs typescript
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
add a comment |
I have the following stateless functional component defined:
import { SFC } from "react";
type ProfileTabContentProps = {
selected: boolean;
};
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) => selected && children;
This fails to compile with the following error:
Type '({ selected, children }: ProfileTabContentProps & { children?: ReactNode; }) => ReactNode' is not assignable to type 'StatelessComponent'.
Type 'ReactNode' is not assignable to type 'ReactElement | null'.
Type 'undefined' is not assignable to type 'ReactElement | null'.
A quick search for related questions all give the same answer, which is very similar to what I've done. What am I missing?
reactjs typescript
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
add a comment |
I have the following stateless functional component defined:
import { SFC } from "react";
type ProfileTabContentProps = {
selected: boolean;
};
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) => selected && children;
This fails to compile with the following error:
Type '({ selected, children }: ProfileTabContentProps & { children?: ReactNode; }) => ReactNode' is not assignable to type 'StatelessComponent'.
Type 'ReactNode' is not assignable to type 'ReactElement | null'.
Type 'undefined' is not assignable to type 'ReactElement | null'.
A quick search for related questions all give the same answer, which is very similar to what I've done. What am I missing?
reactjs typescript
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
I have the following stateless functional component defined:
import { SFC } from "react";
type ProfileTabContentProps = {
selected: boolean;
};
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) => selected && children;
This fails to compile with the following error:
Type '({ selected, children }: ProfileTabContentProps & { children?: ReactNode; }) => ReactNode' is not assignable to type 'StatelessComponent'.
Type 'ReactNode' is not assignable to type 'ReactElement | null'.
Type 'undefined' is not assignable to type 'ReactElement | null'.
A quick search for related questions all give the same answer, which is very similar to what I've done. What am I missing?
reactjs typescript
reactjs typescript
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
asked Nov 21 '18 at 5:28
Kevin ShiKevin Shi
8528
8528
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
Your problem is that selected && children evaluates to React.ReactNode, which if you check the typings, is a union type:
type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;
However, a React.SFC must return a ReactElement, it's definition for the function definition is:
(props: P & { children?: ReactNode }, context?: any): ReactElement<any> | null;
I think you've seen the [truthy] && [render me] pattern used a lot, but usually inside of a larger TSX component, where a React.ReactNode is allowed
You could do this if you want to keep it simple:
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) =>
<>{selected && children}</>
Which just wraps up your expression inside the shorthand for a React.ReactFragment
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53405746%2ftypescript-react-sfc-children-props-type-error%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Your problem is that selected && children evaluates to React.ReactNode, which if you check the typings, is a union type:
type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;
However, a React.SFC must return a ReactElement, it's definition for the function definition is:
(props: P & { children?: ReactNode }, context?: any): ReactElement<any> | null;
I think you've seen the [truthy] && [render me] pattern used a lot, but usually inside of a larger TSX component, where a React.ReactNode is allowed
You could do this if you want to keep it simple:
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) =>
<>{selected && children}</>
Which just wraps up your expression inside the shorthand for a React.ReactFragment
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
add a comment |
Your problem is that selected && children evaluates to React.ReactNode, which if you check the typings, is a union type:
type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;
However, a React.SFC must return a ReactElement, it's definition for the function definition is:
(props: P & { children?: ReactNode }, context?: any): ReactElement<any> | null;
I think you've seen the [truthy] && [render me] pattern used a lot, but usually inside of a larger TSX component, where a React.ReactNode is allowed
You could do this if you want to keep it simple:
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) =>
<>{selected && children}</>
Which just wraps up your expression inside the shorthand for a React.ReactFragment
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
add a comment |
Your problem is that selected && children evaluates to React.ReactNode, which if you check the typings, is a union type:
type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;
However, a React.SFC must return a ReactElement, it's definition for the function definition is:
(props: P & { children?: ReactNode }, context?: any): ReactElement<any> | null;
I think you've seen the [truthy] && [render me] pattern used a lot, but usually inside of a larger TSX component, where a React.ReactNode is allowed
You could do this if you want to keep it simple:
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) =>
<>{selected && children}</>
Which just wraps up your expression inside the shorthand for a React.ReactFragment
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
Your problem is that selected && children evaluates to React.ReactNode, which if you check the typings, is a union type:
type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;
However, a React.SFC must return a ReactElement, it's definition for the function definition is:
(props: P & { children?: ReactNode }, context?: any): ReactElement<any> | null;
I think you've seen the [truthy] && [render me] pattern used a lot, but usually inside of a larger TSX component, where a React.ReactNode is allowed
You could do this if you want to keep it simple:
const ProfileTabContent: SFC<ProfileTabContentProps> = ({ selected, children }) =>
<>{selected && children}</>
Which just wraps up your expression inside the shorthand for a React.ReactFragment
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
answered Nov 21 '18 at 5:42
AlexAlex
2,0241415
2,0241415
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53405746%2ftypescript-react-sfc-children-props-type-error%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
