Combining multiple async actions that have independent reducers
I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.
When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.
author_actions.js
export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
fetchAuthor(authorId).then((author) => {
author.bookIds.each((id) => {
dispatch(fetchBook(id))
})
});
}
I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned
Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?
reactjs redux redux-thunk
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
add a comment |
I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.
When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.
author_actions.js
export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
fetchAuthor(authorId).then((author) => {
author.bookIds.each((id) => {
dispatch(fetchBook(id))
})
});
}
I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned
Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?
reactjs redux redux-thunk
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
add a comment |
I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.
When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.
author_actions.js
export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
fetchAuthor(authorId).then((author) => {
author.bookIds.each((id) => {
dispatch(fetchBook(id))
})
});
}
I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned
Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?
reactjs redux redux-thunk
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.
When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.
author_actions.js
export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
fetchAuthor(authorId).then((author) => {
author.bookIds.each((id) => {
dispatch(fetchBook(id))
})
});
}
I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned
Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?
reactjs redux redux-thunk
reactjs redux redux-thunk
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
asked Nov 20 '18 at 23:34
DecrypterDecrypter
1,19792448
1,19792448
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.
An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:
function fetchAuthorBooks(ids) {
return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
}
usage:
fetchAuthorBooks(author.bookIds).then((books) => {
// the array of books
}).catch((err) => {
// one of the requests failed
})
Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53403202%2fcombining-multiple-async-actions-that-have-independent-reducers%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.
An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:
function fetchAuthorBooks(ids) {
return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
}
usage:
fetchAuthorBooks(author.bookIds).then((books) => {
// the array of books
}).catch((err) => {
// one of the requests failed
})
Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
add a comment |
I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.
An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:
function fetchAuthorBooks(ids) {
return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
}
usage:
fetchAuthorBooks(author.bookIds).then((books) => {
// the array of books
}).catch((err) => {
// one of the requests failed
})
Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
add a comment |
I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.
An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:
function fetchAuthorBooks(ids) {
return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
}
usage:
fetchAuthorBooks(author.bookIds).then((books) => {
// the array of books
}).catch((err) => {
// one of the requests failed
})
Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.
An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:
function fetchAuthorBooks(ids) {
return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
}
usage:
fetchAuthorBooks(author.bookIds).then((books) => {
// the array of books
}).catch((err) => {
// one of the requests failed
})
Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
answered Nov 21 '18 at 5:48
NitsewNitsew
1,324912
1,324912
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53403202%2fcombining-multiple-async-actions-that-have-independent-reducers%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
